[PATCH] drm/scheduler: fix param documentation

Christian König christian.koenig at amd.com
Mon Mar 26 16:57:30 UTC 2018


A bit more commit message would be nice to have, like "There is no more 
@kernel parameter and document the new @guilty parameter".

Am 26.03.2018 um 17:21 schrieb Nayan Deshmukh:
> Signed-off-by: Nayan Deshmukh <nayan26deshmukh at gmail.com>

With the commit message fixed the patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Christian.

> ---
>   drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> index 0d95888ccc3e..1d368bc66ac2 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
> @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
>    * @sched	The pointer to the scheduler
>    * @entity	The pointer to a valid drm_sched_entity
>    * @rq		The run queue this entity belongs
> - * @kernel	If this is an entity for the kernel
>    * @jobs	The max number of jobs in the job queue
> + * @guilty      atomic_t set to 1 when a job on this queue
> + *              is found to be guilty causing a timeout
>    *
>    * return 0 if succeed. negative error code on failure
>   */



More information about the dri-devel mailing list