[PATCH libdrm 1/2] intel: Do not use libpciaccess on Android

John Stultz john.stultz at linaro.org
Mon Mar 26 23:27:45 UTC 2018


On Tue, Mar 20, 2018 at 10:36 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Tomasz Figa <tfiga at google.com>
>
> This patch makes the code not rely anymore on libpciaccess when compiled
> for Android to eliminate ioperm() and iopl() syscalls required by that
> library. As a side effect, the mappable aperture size is hardcoded to 64
> MiB on Android, however nothing seems to rely on this value anyway, as
> checked be grepping relevant code in drm_gralloc and Mesa.
>
> Cc: John Stultz <john.stultz at linaro.org>
> Cc: Rob Herring <rob.herring at linaro.org>
> Cc: John Stultz <john.stultz at linaro.org>
> Cc: Tomasz Figa <tfiga at google.com>
> Signed-off-by: Tomasz Figa <tfiga at google.com>
> [Emil Velikov: rebase against master]
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Tomasz, I've taken the liberty of pulling the patch from the Android
> tree. Hope you don't mind.
> ---

Sorry, being abroad for a conference last week slowed me down and I
didn't get to validate this.

Many thanks for sending this out, I do agree its cleaner then my filtering fix.

I've got this patch (along with the __func__ fix EricE noticed) built
and tested for the HiKey boards and it works ok for me.

Feel free to add my:
Acked-by: John Stultz <john.stultz at linaro.org>

Emil: Do you mind respinning with the fix so Rob or someone can apply?

thanks
-john


More information about the dri-devel mailing list