[PATCH libdrm v2] libdrm: Use readdir instead of readdir_r to avoid build warnings

John Stultz john.stultz at linaro.org
Mon Mar 26 23:31:48 UTC 2018


On Thu, Mar 22, 2018 at 9:51 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 20 March 2018 at 18:17, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>> On Tuesday, 2018-03-20 17:48:23 +0000, Emil Velikov wrote:
>>> From: John Stultz <john.stultz at linaro.org>
>>>
>>> Building libdrm under AOSP, we see the following build warning:
>>> external/libdrm/xf86drm.c:2861:12: warning: 'readdir_r' is deprecated: readdir_r is deprecated; use readdir instead [-Wdeprecated-declarations]
>>>     while (readdir_r(sysdir, pent, &ent) == 0 && ent != NULL) {
>>>            ^
>>>
>>> Building on Linux with glibc produces the same warning.
>>> Thus, this patch replaces readdir_r with readdir.
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102031
>>> Cc: Robert Foss <robert.foss at collabora.com>
>>> Cc: Rob Herring <robh at kernel.org>
>>> Cc: Stefan Schake <stschake at gmail.com>
>>> Cc: John Stultz <john.stultz at linaro.org>
>>> Cc: Eric Engestrom <eric.engestrom at imgtec.com>
>>> Signed-off-by: John Stultz <john.stultz at linaro.org>
>>> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>>> [Emil Velikov: remove unused variables, Eric]
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>
>> I think that's pretty much exactly the patch I have at home :)
>> (and that I forgot to send out last night)
>>
>> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
>>
> Thanks pushed to master.

Sorry again for the slow response here, but an after-the-fact thanks
for sending out the much improved version!

I really appreciate it!
-john


More information about the dri-devel mailing list