[PATCH] drm/mxsfb: add poll_changed event handler to set_par on startup

Daniel Vetter daniel at ffwll.ch
Wed Mar 28 10:14:45 UTC 2018


On Wed, Mar 28, 2018 at 11:08 AM, Lucas Stach <l.stach at pengutronix.de> wrote:
> Am Mittwoch, den 28.03.2018, 09:02 +0200 schrieb Daniel Vetter:
>> On Tue, Mar 27, 2018 at 01:30:04PM +0200, Michael Grzeschik wrote:
>> > On Mon, Mar 26, 2018 at 06:17:44PM +0200, Michael Grzeschik wrote:
>> > > We move drm_kms_helper_poll_init behind the drm_fbdev_cma_init so
>> > > the
>> > > set_par will be called and fb will be active.
>> > >
>> >
>> > As this commit message is not very informative and digging deeper
>> > into
>> > the stubs I came up with another Idea.
>> >
>> > By default drm_kms_helper_hotplug_event could call
>> > drm_fb_helper_output_poll_changed if no other output_poll_changed
>> > was
>> > registered.
>> >
>> > I will send another patch.
>>
>> Will not compile for modular builds since it's an inversion of
>> control
>> between core and helpers.
>>
>> On your original patch:
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>>
>> Hm, mxsfb might be a good candidate for drm-misc too.
>> -Daniel
>
> If you ack FDO bug 103308 I would volunteer to pick up mxsfb patches
> into drm-misc (if Marek is fine with this).

If we maintain a small driver in drm-misc then the main driver
maintainer really should have commit rights, and the MAINTAINERS entry
should be updated to point at drm-misc.git repo. Otherwise the driver
is defacto abandoned. So if Marek is ok, pls create a patch for
MAINTAINERS (and fix up Marek with an fd.o account too).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list