[PATCH v4 2/2] drm/xen-front: Add support for Xen PV display frontend

[Oleksandr Andrushchenko]

On 03/29/2018 10:17 AM, Daniel Vetter wrote:
> On Wed, Mar 28, 2018 at 01:29:46PM +0300, Oleksandr Andrushchenko wrote:
>> Hi, Daniel!
>>
>> I just noticed I have missed one change in the patch:
>> the below must be static.
>>
>> On 03/28/2018 10:42 AM, Daniel Vetter wrote:
>>> +enum drm_mode_status display_mode_valid(struct drm_crtc *crtc,
>>> +		const struct drm_display_mode *mode)
>>> +{
>>> +	struct xen_drm_front_drm_pipeline *pipeline =
>>> +			container_of(crtc,
>> Could you please amend the patch in attachment
>> when merging, so I don't resend?
> Merging is up to you, as soon as you have your commit rights.
Thank you, meanwhile I'll need to rebase onto the latest drm-tip
fixing 2 more minor issues (attached) and making the driver work after
the API change [1]. So, I'll post v4 right after fd.o is back online
with the v3..v4 diff to make review simpler
> -Daniel
Thank you,
Oleksandr
>> Thank you in advance,
>> Oleksandr
>>  From 3a82d76bd3d954056b760e5d1d09e2f96a2786ef Mon Sep 17 00:00:00 2001
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
>> Date: Wed, 28 Mar 2018 13:24:04 +0300
>> Subject: [PATCH] drm/xen-front: Make display_mode_valid static
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
>> ---
>>   drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> index 545049dfaf0a..bd676be5a0db 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> @@ -273,7 +273,7 @@ static void display_update(struct drm_simple_display_pipe *pipe,
>>   	drm_dev_exit(idx);
>>   }
>>   
>> -enum drm_mode_status display_mode_valid(struct drm_crtc *crtc,
>> +static enum drm_mode_status display_mode_valid(struct drm_crtc *crtc,
>>   		const struct drm_display_mode *mode)
>>   {
>>   	struct xen_drm_front_drm_pipeline *pipeline =
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[1] 
https://github.com/freedesktop/drm-misc/commit/0c9c7fd00e17907efb35697ecb9f2df39a0b536c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-xen-front-Free-page-on-event-channel-error-path.patch
Type: text/x-patch
Size: 1413 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180329/19cdca6e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-drm-xen-front-Align-documentation-title-w-other-driv.patch
Type: text/x-patch
Size: 1162 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180329/19cdca6e/attachment-0001.bin>