[PATCH v2] drm/mxsfb: add output_poll_changed handler for initial configuration

Michael Grzeschik m.grzeschik at pengutronix.de
Tue Mar 27 14:40:58 UTC 2018


The driver registers the poll helper but has no output plug handler
registered. Therefor kms_hotplug_event doesn't trigger any configuration
changes on the framebuffer. The initial configuration setup, after
drm_kms_helper_poll_init is started, will also be missed. This is
running the framebuffer unusable. We fix it by assigning
drm_fb_helper_output_poll_changed to output_pull_changed.

Signed-off-by: Michael Grzeschik <m.grzeschik at pengutronix.de>
---
v1 -> v2: - improved the commit message
	  - deleted unnecessary move of drm_kms_helper_poll_init.
	    It was a leftover from using drm_fbdev_cma_hotplug_event
	    which is also calling drm_fb_helper_hotplug_event

 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 1207ffe362505..b8b93e8be1975 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -94,6 +94,7 @@ void mxsfb_disable_axi_clk(struct mxsfb_drm_private *mxsfb)
 
 static const struct drm_mode_config_funcs mxsfb_mode_config_funcs = {
 	.fb_create		= drm_gem_fb_create,
+	.output_poll_changed	= drm_fb_helper_output_poll_changed,
 	.atomic_check		= drm_atomic_helper_check,
 	.atomic_commit		= drm_atomic_helper_commit,
 };
-- 
2.16.1



More information about the dri-devel mailing list