[PATCH] drm: rcar-du: Fix build failure

Kieran Bingham kieran.bingham at ideasonboard.com
Wed May 16 09:32:10 UTC 2018


Hi Laurent,

Thanks for the fix.

On 15/05/18 18:47, Laurent Pinchart wrote:
> Commit 75a07f399cd4 ("drm: rcar-du: Zero-out sg_tables when duplicating
> plane state") introduced a reference to the alpha field of struct
> rcar_du_vsp_plane_state that got removed in commit 301a9b8d5456
> ("drm/rcar-du: Convert to the new generic alpha property"). The issue
> stems from the merge of the two commits through separate branches and
> breaks compilation of the driver. Fix it.
> 
> Fixes: 75a07f399cd4 ("drm: rcar-du: Zero-out sg_tables when duplicating plane state")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>

The kms-tests work fine on this commit.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas at ideasonboard.com>
Tested-by: Kieran Bingham <kieran.bingham+renesas at ideasonboard.com>


> ---
>  drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> index 27a440886b17..c59f0cfabd33 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> @@ -314,7 +314,6 @@ rcar_du_vsp_plane_atomic_duplicate_state(struct drm_plane *plane)
>  		return NULL;
>  
>  	__drm_atomic_helper_plane_duplicate_state(plane, &copy->state);
> -	copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
>  
>  	return &copy->state;
>  }
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180516/af20c2a9/attachment-0001.sig>


More information about the dri-devel mailing list