[PATCH RFC 07/24] drm/lima: add mali 4xx GPU hardware regs
robh at kernel.org
Thu May 24 14:31:33 UTC 2018
On Wed, May 23, 2018 at 7:58 PM, Qiang Yu <yuq825 at gmail.com> wrote:
> On Thu, May 24, 2018 at 1:24 AM, Rob Herring <robh at kernel.org> wrote:
>> On Fri, May 18, 2018 at 05:27:58PM +0800, Qiang Yu wrote:
>>> From: Lima Project Developers <dri-devel at lists.freedesktop.org>
>>> Signed-off-by: Qiang Yu <yuq825 at gmail.com>
>>> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
>>> drivers/gpu/drm/lima/lima_regs.h | 304 +++++++++++++++++++++++++++++++
>>> 1 file changed, 304 insertions(+)
>>> create mode 100644 drivers/gpu/drm/lima/lima_regs.h
>>> diff --git a/drivers/gpu/drm/lima/lima_regs.h b/drivers/gpu/drm/lima/lima_regs.h
>>> new file mode 100644
>>> index 000000000000..ea4a37d69b98
>>> --- /dev/null
>>> +++ b/drivers/gpu/drm/lima/lima_regs.h
>>> @@ -0,0 +1,304 @@
>>> + * Copyright (C) 2010-2017 ARM Limited. All rights reserved.
>> I assume this came from ARM's out of tree kernel driver source. You
>> should document what it was based on.
> Yes, I'll comment it.
>>> + * Copyright (C) 2017-2018 Lima Project
>> IANAL, but is Lima Project a legal entity that can copyright things?
> I heard this second time. Seems it's not a good idea to write like
> this. I'll change the copyright next time.
>>> + *
>>> + * This program is free software and is provided to you under
>>> + * the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation, and any use by
>>> + * you of this program is subject to the terms of such GNU
>>> + * licence.
>>> + *
>>> + * A copy of the licence is included with the program, and
>>> + * can also be obtained from Free Software Foundation, Inc.,
>>> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
>> You can use SPDX tags instead.
> If using SPDX, can I drop these license text? How about the copyright
> text as I see SPDX header doesn't have it?
License and copyright are 2 independent things. Yes, you can drop the
license text, but keep the copyrights.
More information about the dri-devel