[PATCH 0/6] omapdrm: struct_mutex removal

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri May 25 11:15:50 UTC 2018


Hi Tomi,

On Wednesday, 23 May 2018 12:42:48 EEST Tomi Valkeinen wrote:
> On 02/04/18 21:50, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch series removes the usage of struct_mutex from the omapdrm
> > driver in order to switch to gem_free_object_unlocked(). The series is
> > inspired by Daniel Vetter's recent gem_free_object_unlocked() patches
> > (starting with "[PATCH 1/5] staging/vboxvideo: Use
> > gem_free_object_unlocked") and includes patches "[PATCH 4/5] drm/omapdrm:
> > Fix mm_list locking" and "[PATCH] drm/omapdrm: Switch to
> > gem_free_object_unlocked" (the latter modified due to the rebase).
> > 
> > When reviewing Daniel's patches I noticed a potential issue in lock
> > handling which prompted me to go and remove all usage of struct_mutex
> > from the omapdrm driver. Instead of replacing it with a device-wide lock,
> > I have decided to create per-GEM object locks as there is no need, as far
> > as I can see, to serialize operations across separate GEM objects.
> > 
> > The series starts with a bit of cleanup in the form of renaming (1/6) and
> > refactoring (2/6), followed by removal of struct_mutex (3/6 and 4/6). It
> > then ends with Daniel's patches that switch to
> > gem_free_object_unlocked().
> > 
> > The patches are based on top of the latest drm-misc. They have been tested
> > on a Pandaboard.
> 
> For the series:
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> 
> Is this version final, or do you have some pending changes (you hinted
> of a new series version in one of the replies)?

I'm running the last tests and will post v2.

-- 
Regards,

Laurent Pinchart





More information about the dri-devel mailing list