[PATCH v2 8/9] drm/tilcdc: Use drm_fbdev_generic_setup()

Noralf Trønnes noralf at tronnes.org
Thu Nov 1 14:35:42 UTC 2018


Den 29.10.2018 16.55, skrev Jyri Sarha:
> On 25/10/18 23:13, Noralf Trønnes wrote:
>> The CMA helper is already using the drm_fb_helper_generic_probe part of
>> the generic fbdev emulation. This patch makes full use of the generic
>> fbdev emulation by using its drm_client callbacks. This means that
>> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
>> now handled by the emulation code. Additionally fbdev unregister happens
>> automatically on drm_dev_unregister().
>>
>> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
>> driver. This is done to highlight the fact that fbdev emulation is an
>> internal client that makes use of the driver, it is not part of the
>> driver as such. If fbdev setup fails, an error is printed, but the driver
>> succeeds probing.
>>
>> Cc: Jyri Sarha <jsarha at ti.com>
>> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
>> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
>> Acked-by: Sam Ravnborg <sam at ravnborg.org>
> Thanks!
>
> Acked-by: Jyri Sarha <jsarha at ti.com>

Applied to drm-misc-next.

Noralf.



More information about the dri-devel mailing list