[PATCH v2 00/11] DPU cleanups

Jordan Crouse jcrouse at codeaurora.org
Mon Nov 5 23:30:52 UTC 2018


I've been working on various methods to automate code cleanup strategies
and I'm using dpu as my guinea pig. I started out by trying to identify
unused or lightly static inline functions and then that morphed to 
very small functions in general and that then identified a few general
areas of cleanup such as debugfs init/destroy and the dpu_hw_blk_init
users.

Changes in v2: Addressed review comments (thanks!) and added even more
debugfs cleanup

Jordan Crouse (11):
  drm/msm/dpu: Remove dpu_dbg
  drm/msm/dpu: Use DEFINE_SHOW_ATTRIBUTE
  drm/msm/dpu: Remove dpu_crtc_get_mixer_height
  drm/msm/dpu: Remove dpu_crtc_is_enabled()
  drm/msm/dpu: Remove unused functions
  drm/msm/dpu: Cleanup callers of dpu_hw_blk_init
  drm/msm: Make irq_postinstall optional
  drm/msm/dpu: Remove dpu_irq and unused functions
  drm/msm/dpu: Cleanup the debugfs functions
  drm/msm/dpu: Further cleanups for static inline functions
  drm/msm/dpu: Clean up dpu_media_info.h static inline functions

 drivers/gpu/drm/msm/Makefile                  |    4 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c  |   59 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h  |   16 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  122 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h |    7 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      |   76 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h      |   32 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c       | 2393 -----------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h       |  103 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |   55 +-
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h  |    2 +-
 .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c  |   12 +-
 .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c  |    1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c    |   10 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h    |    2 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |    9 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c    |   18 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c   |   18 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h   |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c     |   24 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h     |    5 -
 .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c   |   18 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h   |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c   |   21 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h   |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c    |   20 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h    |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c   |    1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c       |   66 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h       |   59 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  188 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       |    8 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c      |    8 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c     |  108 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c      |   24 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h      |   15 +-
 .../gpu/drm/msm/disp/dpu1/msm_media_info.h    |  164 +-
 drivers/gpu/drm/msm/msm_drv.c                 |    6 +-
 38 files changed, 235 insertions(+), 3479 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h

-- 
2.18.0



More information about the dri-devel mailing list