[PATCH 11/11] drm/msm/dpu: Clean up dpu_media_info.h static inline functions

Sam Ravnborg sam at ravnborg.org
Tue Nov 6 16:16:00 UTC 2018


Hi Jordan.

>  	case COLOR_FMT_P010_UBWC:
> -		alignment = 256;
> -		stride = MSM_MEDIA_ALIGN(width * 2, alignment);
> +		stride = MSM_MEDIA_ALIGN(width * 2, 256);
>  		break;
>  	case COLOR_FMT_P010:
> -		alignment = 128;
> -		stride = MSM_MEDIA_ALIGN(width*2, alignment);
> -		break;
> -	default:
> +		stride = MSM_MEDIA_ALIGN(width*2, 128);

As you touch this line, could you please add spaces around '*'
Same goes for use of '/' in a few places.

I assume checkpatch would have told you to fix this.

With this fixed you can add my:
Acked-by: Sam Ravnborg <sam at ravnborg.org>

	Sam


More information about the dri-devel mailing list