[PATCH] drm/nouveau: tegra: Initialize mode configuration

Ilia Mirkin imirkin at alum.mit.edu
Wed Nov 7 15:52:11 UTC 2018


On Wed, Nov 7, 2018 at 10:34 AM Thierry Reding <thierry.reding at gmail.com> wrote:
>
> On Tue, Nov 06, 2018 at 06:41:22PM +0200, Ville Syrjälä wrote:
> > On Tue, Nov 06, 2018 at 05:24:15PM +0100, Thierry Reding wrote:
> > > From: Thierry Reding <treding at nvidia.com>
> > >
> > > Irrespective of whether or not the device has any usable outputs, the
> > > modesetting helpers will try to register all the resources such as CRTCs
> > > and planes. Unfortunately, the helpers rely on drm_mode_config_init() to
> > > properly set up internal data structures. Since the Tegra GPU does not
> > > have a display engine, the Nouveau driver doesn't set this up for Tegra,
> > > which results in the following oops on driver probe:
> >
> > Remove DRIVER_MODESET ?
>
> Yeah, that works as well. Technically I suppose somebody could be
> instantiating the IP in an SoC and include a display engine, in which
> case we'd need the DRIVER_MODESET feature again, but I'm not aware of
> anyone doing that, so it may not be worth planning for that at this
> point.

I thought DRIVER_MODESET was required even for rendernodes. Is that no
longer the case?

Note that e.g. GF117 GPUs also don't have a display engine hooked up
in nouveau (or in hardware).

  -ilia


More information about the dri-devel mailing list