[PATCH] drm/syncobj: disable the timeline UAPI for now

Daniel Vetter daniel at ffwll.ch
Thu Nov 8 08:56:54 UTC 2018


On Thu, Nov 08, 2018 at 09:42:08AM +0100, Christian König wrote:
> Until we have sorted out all problems.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  include/drm/drm_syncobj.h | 3 +++
>  include/uapi/drm/drm.h    | 1 -
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_syncobj.h b/include/drm/drm_syncobj.h
> index 29244cbcd05e..ffd1f4fcf519 100644
> --- a/include/drm/drm_syncobj.h
> +++ b/include/drm/drm_syncobj.h
> @@ -30,6 +30,9 @@
>  
>  struct drm_syncobj_cb;
>  
> +/* Move the define here for the moment to avoid exposing the UAPI just yet */
> +#define DRM_SYNCOBJ_CREATE_TYPE_TIMELINE (1 << 1)

Also needs the EINVAL check in drm_syncobj_create_ioctl() updated. With
that:

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> +
>  enum drm_syncobj_type {
>  	DRM_SYNCOBJ_TYPE_BINARY,
>  	DRM_SYNCOBJ_TYPE_TIMELINE
> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> index cebdb2541eb7..300f336633f2 100644
> --- a/include/uapi/drm/drm.h
> +++ b/include/uapi/drm/drm.h
> @@ -717,7 +717,6 @@ struct drm_prime_handle {
>  struct drm_syncobj_create {
>  	__u32 handle;
>  #define DRM_SYNCOBJ_CREATE_SIGNALED (1 << 0)
> -#define DRM_SYNCOBJ_CREATE_TYPE_TIMELINE (1 << 1)
>  	__u32 flags;
>  };
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list