[PATCH DRM] drm: msm: disp: dpu1: Use DRM_DEV_* instead of DPU_*

[Mamta Shukla]

On Wed, Nov 7, 2018 at 12:25 AM Sean Paul <sean at poorly.run> wrote:
>
> On Sat, Oct 20, 2018 at 11:33:54PM +0530, Mamta Shukla wrote:
> > Use DRM_DEV_ERROR/DEBUG instead of DPU_ERROR/DEBUG  to generate
> > drm-formatted specific log messages in the Kernel log in case of
> > multiple instances.
> >
> > Signed-off-by: Mamta Shukla <mamtashukla555 at gmail.com>
>
> Hi Mamta,
> Thanks for sending this patch, but I don't think it's going to even compile.
> DRM_DEV_* takes a struct device * pointer as the first argument, and it's not
> being passed in anywhere. Make sure you compile test with CONFIG_DRM_MSM enabled
>
Thank you for pointing this out. Definitely DRM_DEV_* requires pointer
to function or the device pointer along with
message string. I had compiled this before submitting the patch. But I
missed out enabling the DRM_MSM.
Is it good to write v2 of above patch with mentioning/stating pointer
to function so that in DEBUG message function
name is also available with error message?


> > ---
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c       |  58 +++----
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c      |  60 +++----
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c           | 176 ++++++++++-----------
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c        | 134 ++++++++--------
> >  .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c   |  40 ++---
> >  .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c   |  42 ++---
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c        |  10 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c         |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c         |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c        |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c          |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c    |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c        |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c         |   2 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c            |   4 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |  90 +++++------
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c           |  10 +-
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c          | 134 ++++++++--------
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c             |  96 +++++------
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c           |  32 ++--
> >  21 files changed, 451 insertions(+), 451 deletions(-)
> >
>
> /snip
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS



-- 
Mamta Shukla