[PATCH] drm/bridge: Fix 0-day build error

[Fabrizio Castro]

Hi Boris,

> From: Boris Brezillon <boris.brezillon at bootlin.com>
> Sent: 19 November 2018 12:51
> Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
>
> Hi Fabrizio,
>
> The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> explanation of what is problematic in the subject rather than "Fix
> 0-day build error". Maybe something like
>
> "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
>
> On Mon, 19 Nov 2018 12:44:23 +0000
> Fabrizio Castro <fabrizio.castro at bp.renesas.com> wrote:
>
> > kbuild test robot reports:
> >
> > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> >
> > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > instead.
> >
>
> You need a fixes tag here:
>
> Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")

Thank you for spotting this, I'll send a v2 right away.

Cheers,
Fab

>
> Thanks,
>
> Boris
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro at bp.renesas.com>
> > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > ---
> >  drivers/gpu/drm/bridge/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 9eeb8ef..2fee47b 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -95,6 +95,7 @@ config DRM_SII902X
> >  depends on OF
> >  select DRM_KMS_HELPER
> >  select REGMAP_I2C
> > +select I2C_MUX
> >  ---help---
> >    Silicon Image sii902x bridge chip driver.
> >




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.