[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 22 16:09:37 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=106175

--- Comment #60 from Brandon Wright <bearoso at gmail.com> ---
> There are larger problems within amdgpu_dm's commit tail that if addressed 
> should resolve this issue for compton I'd imagine.
Honestly, I don't care about compton. I don't think you realize the effects of
this issue. It seriously affects performance when the cursor is in motion with
any page-flipping application. GNOME and KDE, while the window motion is less
affected, stutter in composited client applications. 

> This is a nice attempt but it only resolves the problem because it relies on
> the blocking behavior in atomic check that amdgpu_dm currently does 
> (and shouldn't be doing).
>
> Asynchronous updates can and will occur in parallel with other commits on 
> worker threads. Without the wait in atomic_check you'll see the IGT legacy 
> cursor tests break with this patch (and there will probably be system faults 
> as well).
You'd have to point this out to me, because I didn't see anything that would
obviously block, unless it's buried in dc_validate_plane.

Since, as you say, atomic_check is blocking for now, why not work around this
issue with a tiny change. If someone ever gets around to doing things the
correct way it's no big deal to remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20181122/eb06858a/attachment.html>


More information about the dri-devel mailing list