[PATCH 2/3] backlight/arcxcnn fix vendor prefix

Brian Dodge bdodge09 at gmail.com
Tue Nov 27 00:44:14 UTC 2018


Thank you Pavel, that is a good point.

The chip vendor has indicated that there is no reason to maintain the 
old/improper prefix and wishes to go forward (only) with the "arctic" 
prefix and any existing dts files are or will be updated.

On 11/11/18 6:30 AM, Pavel Machek wrote:
> Hi!
>
>> The vendor-prefixes.txt file properly refers to ArcticSand
>> as arctic but the driver improperly abbreviated the prefix
>> to arc. This was a mistake in the original patch
>>
>> Signed-off-by: Brian Dodge <bdodge09 at gmail.com>
>> ---
>>   drivers/video/backlight/arcxcnn_bl.c | 22 +++++++++++-----------
>>   1 file changed, 11 insertions(+), 11 deletions(-)
>>
>>    *
>> - * Copyright 2016 ArcticSand, Inc.
>> - * Author : Brian Dodge <bdodge at arcticsand.com>
>> + * Copyright 2018 pSemi, Inc.
>> + * Author : Brian Dodge <bdodge at psemi.com>
> Ummm. Copyright 2016-2018?
>
>> @@ -202,27 +202,27 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
>>   	if (ret == 0)
>>   		lp->pdata->initial_brightness = prog_val;
>>
>> -	ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
>> +	ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
>>   	if (ret == 0)
>>   		lp->pdata->led_config_0 = (u8)prog_val;
>>
> If there's a dts using this, you want to update it at the same
> time. You may want to support both names going forward.
> 									Pavel


More information about the dri-devel mailing list