[PATCH v3 4/5] drm/framebuffer: Include linux/sched.h in header file

[Daniel Vetter]

On Wed, Nov 28, 2018 at 10:27:12PM +0100, Noralf Trønnes wrote:
> A cleanup of the includes in drm_fb_cma_helper resulted in:
> 
>   CC [M]  drivers/gpu/drm/drm_fb_cma_helper.o
> In file included from drivers/gpu/drm/drm_fb_cma_helper.c:21:0:
> include/drm/drm_framebuffer.h:128:12: error: ‘TASK_COMM_LEN’ undeclared here (not in a function)
>   char comm[TASK_COMM_LEN];

Huh, I'm not seeing this. And we have 3 defconfigs for compile-testing,
they still seem to work. Which patch broke this? Should be quick to bisect
since fully automateable ... And would be good to have the Fixes: tag for
this.

Anyway, Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Fix it by including linux/sched.h.
> 
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> ---
>  include/drm/drm_framebuffer.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
> index c94acedfb08e..d4ce58568fa6 100644
> --- a/include/drm/drm_framebuffer.h
> +++ b/include/drm/drm_framebuffer.h
> @@ -25,6 +25,7 @@
>  
>  #include <linux/list.h>
>  #include <linux/ctype.h>
> +#include <linux/sched.h>
>  #include <drm/drm_mode_object.h>
>  
>  struct drm_framebuffer;
> -- 
> 2.15.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch