[PATCH 2/4] gpu: ipu-v3: prg: add function to get channel configure status

Philipp Zabel p.zabel at pengutronix.de
Fri Oct 5 14:16:11 UTC 2018


On Fri, 2018-09-14 at 18:59 +0200, Lucas Stach wrote:
> This allows channels using the PRG to check if a requested configuration
> update has been applied or is still pending.
> 
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
> ---
>  drivers/gpu/ipu-v3/ipu-prg.c | 16 ++++++++++++++++
>  include/video/imx-ipu-v3.h   |  1 +
>  2 files changed, 17 insertions(+)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
> index 38a3a9764e49..f78463cf1c15 100644
> --- a/drivers/gpu/ipu-v3/ipu-prg.c
> +++ b/drivers/gpu/ipu-v3/ipu-prg.c
> @@ -347,6 +347,22 @@ int ipu_prg_channel_configure(struct ipuv3_channel *ipu_chan,
>  }
>  EXPORT_SYMBOL_GPL(ipu_prg_channel_configure);
>  
> +int ipu_prg_channel_configure_done(struct ipuv3_channel *ipu_chan)

Same as patch 1, I'd prefer ipu_prg_channel_configure_pending instead.
Also the return value is only ever used as a boolean, so just make this
return bool.

> +{
> +	int prg_chan = ipu_prg_ipu_to_prg_chan(ipu_chan->num);
> +	struct ipu_prg *prg = ipu_chan->ipu->prg_priv;
> +	struct ipu_prg_channel *chan;
> +
> +	if (prg_chan < 0)
> +		return -EINVAL;

Since nonexisting channels can't have updates pending, let's just return
false here.

regards
Philipp


More information about the dri-devel mailing list