[PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0

[Andrzej Hajda]

On 11.10.2018 10:48, Linus Walleij wrote:
> On Tue, Oct 9, 2018 at 9:26 PM Sam Ravnborg <sam at ravnborg.org> wrote:
>> On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote:
>>> +  - reset-gpios: a GPIO spec for the reset pin (active low)
>> That it is active low is part of the GPIO part and should not
>> be mandated as part of the binding?
> The fact that the consumer requires the line to be asserted
> low is an electronic property of the component, i.e. the panel,
> and it is just there explaining that if you set it to anything else than
> active low, you are probably doing something wrong.
>
> Should I specify "must be set as active low" instead to make
> it clear?

Common practice is as you wrote, I think it is OK.

Regards
Andrzej

>
>>> +             reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
>> This line specifies if ACTIVE HIGH or LOW.
> Yep we always specify that on the consumer side. Or we should
> always do that ... but since this panel is by defintion expecting
> an active low signal, anything else would be an error and that
> is what I am trying to say in the description.
>
> Yours,
> Linus Walleij
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel