[PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

[Daniel Vetter]

On Thu, Oct 11, 2018 at 11:58 AM Alexandru-Cosmin Gheorghe
<Alexandru-Cosmin.Gheorghe at arm.com> wrote:
>
> On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote:
> > On Mon, Oct 08, 2018 at 09:52:04AM +0000, Alexandru-Cosmin Gheorghe wrote:
> > > Shouldn't that be enough for validating this patches?
> >
> > I don't think so, right now we don't have specific tests for e.g. the new
> > min_pitch function you're adding. Igt is still fairly far away from
> > providing full coverage. And it can't provide coverage for new features
> > ofc, without someone adding those tests.
>
> Proabably drm/selftests makes more sense for the drm_format_info*
> helpers I'm hoping is relatively painless to add, I'm not very sure
> about check_framebuffer and drm_framebuffer_create, but I'll have a
> look into it.

This might help:

https://www.spinics.net/lists/dri-devel/msg191131.html

and on the igt side:

https://lists.freedesktop.org/archives/igt-dev/2018-October/006257.html

I've already suggested we rename that bucket of self-tests to drm_kms,
so that we can stuff all kinds of kms related selftests in there.
Instead of having to wire up the scaffolding for all of them
individually.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch