[PATCH v2] drm/virtio: document drm_dev_set_unique workaround

[Emil Velikov]

On Tue, 30 Oct 2018 at 05:34, Gerd Hoffmann <kraxel at redhat.com> wrote:
>
> On Wed, Oct 24, 2018 at 03:42:52PM +0100, Emil Velikov wrote:
> > From: Emil Velikov <emil.velikov at collabora.com>
> >
> > A while back we removed it, yet that lead to regressions. At some later
> > point, I've attempted to remove it again without fully grasping the
> > unique (pun intended) situation that virtio is in.
> >
> > Add a bulky comment to document why the call should stay as-is, for the
> > next person who's around.
> >
> > As a Tl;Dr: virtio sits on top of struct virtio_device, which confuses
> > dev_is_pci(), wrong info gets sent to userspace and X doesn't start.
> > Driver needs to explicitly call drm_dev_set_unique() to keep it working.
> >
> > v2: Fix handful of typos (Laszlo)
> >
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > Cc: Hans de Goede <hdegoede at redhat.com>
> > Cc: Laszlo Ersek <lersek at redhat.com>
> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> > Reviewed-by: Laszlo Ersek <lersek at redhat.com>
>
> Reviewed-by: Gerd Hoffmann <kraxel at redhat.com>
>
Thanks Gerd.

> > Sending it out for posterity-sake. Modulo any objections I'll merge
> > this via drm-misc.
>
> Ah, good, leaving merging to you then ;)
>
I've pushed the commit to drm-misc with Laszlo's RB a bit before your reply.
Hope it's not a problem, but for the future I'll be more patient.

-Emil