[PATCH 2/2] drm/exynos/fbdev: do not skip fbdev init if there are no connectors

[Marek Szyprowski]

Hi,


On 2018-10-26 12:13, Andrzej Hajda wrote:
> Since connectors can be created dynamically, fbdev should be initialized
> even if there are no connectors at the moment. Otherwise fbdev will
> not be created even after connector's appearance.
> The patch fixes lack of fbdev on rinato and trats boards.
>
> Fixes: 6afb7721e2a0 ("drm/exynos: move connector creation to attach callback")
> Reported-by: Marek Szyprowski <m.szyprowski at samsung.com>
> Signed-off-by: Andrzej Hajda <a.hajda at samsung.com>

Together with v2 of "drm/exynos/dsi: register connector if it is created
after
drm bind" patch this finally restores /dev/fb0 emulation on Rinato and Trats
boards.

Tested-by: Marek Szyprowski <m.szyprowski at samsung.com>

> ---
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index 918dd2c82209..01d182289efa 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -192,7 +192,7 @@ int exynos_drm_fbdev_init(struct drm_device *dev)
>  	struct drm_fb_helper *helper;
>  	int ret;
>  
> -	if (!dev->mode_config.num_crtc || !dev->mode_config.num_connector)
> +	if (!dev->mode_config.num_crtc)
>  		return 0;
>  
>  	fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland