[PATCH] drm: Suppress user controlled spam for invalid drm_wait_vblank_ioctl

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 4 18:53:33 UTC 2018


Quoting Daniel Vetter (2018-09-04 14:08:12)
> On Tue, Sep 04, 2018 at 12:57:19PM +0100, Chris Wilson wrote:
> > The ioctl arguments are under control of the user and as such we should
> > resist any temptation to flood the kernel logs with their errors.
> > Relegate the DRM_ERROR to a DRM_DEBUG so the user has to opt into
> > hearing of their own mistakes. (One day we will have a small ringbuffer
> > attached to the task, so that the concerned process can inspect its own
> > debug info for EINVAL without them being hitting syslog at all.)
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> igt for this would be lovely. Either way Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Pushed and negative igt sent.
-Chris


More information about the dri-devel mailing list