[PATCH libdrm 02/11] amdgpu: use new symbols checking script

[Emil Velikov]

On 4 April 2018 at 16:41, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>  amdgpu/Makefile.am         |  1 +
>  amdgpu/amdgpu-symbol-check | 19 ++++++-------------
>  2 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/amdgpu/Makefile.am b/amdgpu/Makefile.am
> index a1b0d05c1457ae681ac8..4ad6949e81ddbd11078e 100644
> --- a/amdgpu/Makefile.am
> +++ b/amdgpu/Makefile.am
> @@ -47,5 +47,6 @@ libdrm_amdgpuinclude_HEADERS = $(LIBDRM_AMDGPU_H_FILES)
>  pkgconfigdir = @pkgconfigdir@
>  pkgconfig_DATA = libdrm_amdgpu.pc
>
> +AM_TESTS_ENVIRONMENT = top_srcdir='$(top_srcdir)'
Gut suggests that the absolute abs_foo path will be needed here - not
too sure though.

> diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
> index 90b7a1d633c0b2143f29..5ed24b906c0228233f71 100755
> --- a/amdgpu/amdgpu-symbol-check
> +++ b/amdgpu/amdgpu-symbol-check
> @@ -1,15 +1,10 @@
>  #!/bin/bash
> +set -eu
>
> -# The following symbols (past the first five) are taken from the public headers.
> -# A list of the latter should be available Makefile.am/libdrm_amdgpuinclude_HEADERS
> +LIB=.libs/libdrm_amdgpu.so
>
I think this will break meson - it passes the library name as an arg.
One solution is to set LIB (feel free to pick better name), just like NM.

-Emil