[Bug 106928] When starting a match Rocket League crashes on "Go"
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Sep 7 17:36:24 UTC 2018
https://bugs.freedesktop.org/show_bug.cgi?id=106928
Andrés Gómez García <agomez at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |agomez at igalia.com,
| |sroland at vmware.com
--- Comment #21 from Andrés Gómez García <agomez at igalia.com> ---
Roland, is this fixed by?
commit 817efd89685efc6b5866e09cbdad01c4ff21c737
Author: Roland Scheidegger <sroland at vmware.com>
Date: Wed Jul 4 04:44:17 2018 +0200
r600/sb: fix crash in fold_alu_op3
fold_assoc() called from fold_alu_op3() can lower the number of src to 2,
which then leads to an invalid access to n.src[2]->gvalue().
This didn't seem to have caused much harm in the past, but on Fedora 28
it will crash (presumably because -D_GLIBCXX_ASSERTIONS is used, although
with libstdc++ 4.8.5 this didn't do anything, -D_GLIBCXX_DEBUG was
needed to show the issue).
An alternative fix would be to instead call fold_alu_op2() from within
fold_assoc() when the number of src is reduced and return always TRUE
from fold_assoc() in this case, with the only actual difference being
the return value from fold_alu_op3() then. I'm not sure what the return
value actually should be in this case (or whether it even can make a
difference).
https://bugs.freedesktop.org/show_bug.cgi?id=106928
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Dave Airlie <airlied at redhat.com>
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180907/51d1ff56/attachment.html>
More information about the dri-devel
mailing list