[PATCH 07/20] drm/rcar-du: Use drm_fbdev_generic_setup()

Sam Ravnborg sam at ravnborg.org
Sun Sep 9 14:00:48 UTC 2018


On Sat, Sep 08, 2018 at 03:46:35PM +0200, Noralf Trønnes wrote:
> The CMA helper is already using the drm_fb_helper_generic_probe part of
> the generic fbdev emulation. This patch makes full use of the generic
> fbdev emulation by using its drm_client callbacks. This means that
> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
> now handled by the emulation code. Additionally fbdev unregister happens
> automatically on drm_dev_unregister().
> 
> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
> driver. This is done to highlight the fact that fbdev emulation is an
> internal client that makes use of the driver, it is not part of the
> driver as such. If fbdev setup fails, an error is printed, but the driver
> succeeds probing.
> 
> Use the drm_mode_config_helper_suspend/resume helpers instead of open
> coding it.
Seems a bit un-related to the rest of the patch.
But the changes looks fine (from my limited DRM experience that is).

	Sam


More information about the dri-devel mailing list