[PATCH v2 4/4] drm/fb-helper: improve documentation and print warnings

Gerd Hoffmann kraxel at redhat.com
Mon Sep 10 06:22:31 UTC 2018


> >   * This function sets up generic fbdev emulation for drivers that supports
> > - * dumb buffers with a virtual address and that can be mmap'ed.
> > + * dumb buffers with a virtual address and that can be mmap'ed. If the driver
> > + * does not support these functions, it could use drm_fb_helper_fbdev_setup().
> > + * This function can only be used with devices created using drm_dev_register().
> 
> This last line is misleading, since every drm device is called with
> drm_dev_register(). It's just not all called by driver code directly.
> With this line removed:
> 
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> I'll leave it to Gerd to apply this all.

Fixed and pushed.

cheers,
  Gerd



More information about the dri-devel mailing list