[PATCH 05/14] drm/vmwgfx: add a new interface for plane update on a display unit

[Thomas Hellstrom]

On 09/06/2018 01:38 AM, Deepak Rawat wrote:
> Add a new struct vmw_du_update_plane similar to vmw_kms_dirty which
> represent the flow of operations needed to update a display unit from
> surface or bo(blit a new framebuffer).
>
> Signed-off-by: Deepak Rawat <drawat at vmware.com>
> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 108 +++++++++++++++++++++
>   drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 143 ++++++++++++++++++++++++++++
>   2 files changed, 251 insertions(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 1edbae73d6d6..c1de8f609bf4 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -30,6 +30,7 @@
>   #include <drm/drm_atomic.h>
>   #include <drm/drm_atomic_helper.h>
>   #include <drm/drm_rect.h>
> +#include <drm/drm_damage_helper.h>
>   
>   /* Might need a hrtimer here? */
>   #define VMWGFX_PRESENT_RATE ((HZ / 60 > 0) ? HZ / 60 : 1)
> @@ -3077,3 +3078,110 @@ void vmw_kms_lost_device(struct drm_device *dev)
>   {
>   	drm_atomic_helper_shutdown(dev);
>   }
> +
> +/**
> + * vmw_du_helper_plane_update - helper to do plane update on display unit
> + *
> + * @update: The closure structure.
> + *
> + * RETURNS:
> + *
> + * 0 on success or a negative error code on failure.
> + */
We should try to comply better with the kerneldoc description
https://www.kernel.org/doc/Documentation/kernel-doc-nano-HOWTO.txt

Otherwise This patch LGTM.