[PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

Noralf Trønnes noralf at tronnes.org
Mon Sep 10 13:00:31 UTC 2018

Den 10.09.2018 14.31, skrev Alexey Brodkin:
> Hi Noralf,
> On Sat, 2018-09-08 at 15:46 +0200, Noralf Trønnes wrote:
>> The CMA helper is already using the drm_fb_helper_generic_probe part of
>> the generic fbdev emulation. This patch makes full use of the generic
>> fbdev emulation by using its drm_client callbacks. This means that
>> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
>> now handled by the emulation code. Additionally fbdev unregister happens
>> automatically on drm_dev_unregister().
>> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
>> driver. This is done to highlight the fact that fbdev emulation is an
>> internal client that makes use of the driver, it is not part of the
>> driver as such. If fbdev setup fails, an error is printed, but the driver
>> succeeds probing.
>> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
>> ---
> Thanks for making these improvements!

Glad you like it.
Funny how a simple idea can turn into 6 months of work.

> I'm wondering what is a base for these changes so that I may try it on
> my board?
> Preferably I'd like to get a link to the tag in your git tree with all
> the prerequisites in place.

It's only this one patch to apply for you.
I replied to the cover letter with some more context.


More information about the dri-devel mailing list