[PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m
maxime.ripard at bootlin.com
Thu Sep 13 08:02:13 UTC 2018
On Wed, Sep 12, 2018 at 05:53:39PM +0200, Daniel Vetter wrote:
> On Wed, Sep 12, 2018 at 5:47 PM, Maxime Ripard
> <maxime.ripard at bootlin.com> wrote:
> > On Wed, Sep 12, 2018 at 04:25:36PM +0200, Daniel Vetter wrote:
> >> On Wed, Sep 12, 2018 at 11:53 AM, Maxime Ripard
> >> <maxime.ripard at bootlin.com> wrote:
> >> > On Tue, Sep 11, 2018 at 10:17:02PM +0200, Daniel Vetter wrote:
> >> >> On Tue, Sep 11, 2018 at 01:33:25PM +0200, Maxime Ripard wrote:
> >> >> > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in
> >> >> > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module:
> >> >> >
> >> >> > ERROR: "sun8i_tcon_top_de_config" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] undefined!
> >> >> > ERROR: "sun8i_tcon_top_set_hdmi_src" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] undefined!
> >> >> > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] undefined!
> >> >> >
> >> >> > This solves the problem by adding a silent symbol for the tcon_top module,
> >> >> > building it as a separate module in exactly the cases that we need it,
> >> >> > but in a way that it is reachable by the other modules.
> >> >> >
> >> >> > Fixes: cf77d79b4e29 ("drm/sun4i: tcon: Add another way for matching mixers with tcon")
> >> >> > Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON")
> >> >> > Tested-by: Jon Hunter <jonathanh at nvidia.com>
> >> >> > Signed-off-by: Maxime Ripard <maxime.ripard at bootlin.com>
> >> >>
> >> >> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> >> >>
> >> >> But I can't help myself and drop the usual questions when I see a small
> >> >> soc driver with more Kconfigs than anything else ... is all this pain
> >> >> worth it? I know that maybe the desktop approach of stuffing half a
> >> >> million lines of driver code into one .ko might be a bit too much for
> >> >> socs, but this seems overkill.
> >> >>
> >> >> I'm also pretty sure it's not justified by any real data, compared to
> >> >> overall code size of a drm stack, that shows it's a substantial enough
> >> >> saving that it's worth it.
> >> >
> >> > I'm currently running on a project where the boot time to a qt
> >> > application from power off should be less than a second. You want to
> >> > remove anything you can spare in some situations. And yeah, DRM is the
> >> > biggest thing in the way to do that.
> >> Oh I know all about the 1s people. But is binary size really that
> >> important figure? I know it's a bit more to load&decompress, but it
> >> shouldn't have any impact on anything running at runtime.
> > It really depends on the combination of the CPU speed, the storage
> > speed, and the compression algorithm. To give you a figure, a quite
> > good storage device in our case has a bandwith of 10MB/s. If you add a
> > MB, you lose a tenth of your budget, decompression excluded.
> > The sole edid_cea_modes, drm_dmt_modes and edid_est_modes, combined,
> > already take around 50kB. That's around .5% of our time budget just
> > dedicated to loading structures we will never need, without the option
> > to compile them out.
> Yup, if you want to make drm_edid.c optional, you need LTO. Because I
> think we've already gone way overboard with making stuff optional in
> the drm core, there's lots of silly little Kconfigs with imo
> questionable value. Also, 50kb ... what does that look like
> compressed? Should compress exceedingly well.
> But that's not what I asked about really, I asked about all the
> Kconfigs in su4i. Are those worth it? Especially compared to fixing
> this for real, using something like LTO (plus making a few things
> hard-coded, per machine configuration, so that gcc can figure it all
You're asking whether a 5 minutes effort is worth it compared to a 5
weeks one (at best) to port the LTO patches, making it sure it works
ok on ARM, and then debugging whether some entry point has been
removed or not.
Plus, given that it's a driver that could or couldn't be loaded
depending on the device tree, you would have to keep that driver in
even with LTO, even though you know you have zero chance to execute
that code at runtime.
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the dri-devel