[PATCH 17/20] drm/tve200: Use drm_fbdev_generic_setup()

Linus Walleij linus.walleij at linaro.org
Tue Sep 18 22:10:41 UTC 2018


On Sat, Sep 8, 2018 at 6:53 AM Noralf Trønnes <noralf at tronnes.org> wrote:

> The CMA helper is already using the drm_fb_helper_generic_probe part of
> the generic fbdev emulation. This patch makes full use of the generic
> fbdev emulation by using its drm_client callbacks. This means that
> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
> now handled by the emulation code. Additionally fbdev unregister happens
> automatically on drm_dev_unregister().
>
> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
> driver. This is done to highlight the fact that fbdev emulation is an
> internal client that makes use of the driver, it is not part of the
> driver as such. If fbdev setup fails, an error is printed, but the driver
> succeeds probing.
>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>

Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij


More information about the dri-devel mailing list