[PATCH libdrm 3/3] radeon: add missing drm_public exports

[Michel Dänzer]

On 2018-09-20 8:31 p.m., Eric Engestrom wrote:
> On Thursday, 2018-09-20 18:21:41 +0100, Eric Engestrom wrote:
>> On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote:
>>> On 2018-09-20 5:58 p.m., Eric Engestrom wrote:
>>>> Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions"
>>>> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>>>> Cc: Mark Janes <mark.a.janes at intel.com>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006
>>>> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
>>>> ---
>>>>  radeon/radeon_bo.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/radeon/radeon_bo.c b/radeon/radeon_bo.c
>>>> index cd06c26ee152d68f893d..91929532d5bf6e0daca8 100644
>>>> --- a/radeon/radeon_bo.c
>>>> +++ b/radeon/radeon_bo.c
>>>> @@ -67,13 +67,13 @@ drm_public struct radeon_bo *radeon_bo_unref(struct radeon_bo *bo)
>>>>      return boi->bom->funcs->bo_unref(boi);
>>>>  }
>>>>  
>>>> -int radeon_bo_map(struct radeon_bo *bo, int write)
>>>> +drm_public int radeon_bo_map(struct radeon_bo *bo, int write)
>>>>  {
>>>>      struct radeon_bo_int *boi = (struct radeon_bo_int *)bo;
>>>>      return boi->bom->funcs->bo_map(boi, write);
>>>>  }
>>>>  
>>>> -int radeon_bo_unmap(struct radeon_bo *bo)
>>>> +drm_public int radeon_bo_unmap(struct radeon_bo *bo)
>>>>  {
>>>>      struct radeon_bo_int *boi = (struct radeon_bo_int *)bo;
>>>>      return boi->bom->funcs->bo_unmap(boi);
>>>>
>>>
>>> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>>> Tested-by: Michel Dänzer <michel.daenzer at amd.com>
>>
>> Thanks!
>>
>> radeon_cs_space_check was also missing, but my grep didn't catch it
>> because radeon_cs_space_check_with_bo matched my weak grep skills...
>>
>> I added drm_public to it too, can I still apply your tags, or do you
>> want a v2?
> 
> I ended up pushing it with your r-b and t-b, because I'm going home and
> would rather not have left it like that too long :)

Good catch and good call, thanks again.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer