[PATCH v4 2/6] drm: use drm_driver_legacy_fb_format in drm_gem_fbdev_fb_create

[Daniel Vetter]

On Fri, Sep 21, 2018 at 03:47:00PM +0200, Gerd Hoffmann wrote:
> Creating framebuffers for fbdev emulation should use the correct format
> code too, so switch drm_gem_fbdev_fb_create() over to use the new
> drm_driver_legacy_fb_format() function.
> 
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>

First two patches look really neat now, you can upgrade to

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> index 7607f9cd6f..ded7a379ac 100644
> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> @@ -316,8 +316,8 @@ drm_gem_fbdev_fb_create(struct drm_device *dev,
>  	if (pitch_align)
>  		mode_cmd.pitches[0] = roundup(mode_cmd.pitches[0],
>  					      pitch_align);
> -	mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
> -							sizes->surface_depth);
> +	mode_cmd.pixel_format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
> +							    sizes->surface_depth);
>  	if (obj->size < mode_cmd.pitches[0] * mode_cmd.height)
>  		return ERR_PTR(-EINVAL);
>  
> -- 
> 2.9.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch