[PATCH v1] drm/tegra: dpaux: Fix always-failing probing of the driver

Dmitry Osipenko digetx at gmail.com
Fri Sep 21 11:42:41 UTC 2018


Some of definitions in the code changed the meaning, unfortunately one
place missed the change.

Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support")
Cc: <stable at vger.kernel.org> # v4.8+
Signed-off-by: Dmitry Osipenko <digetx at gmail.com>
---

I don't have HW to test DPAUX driver, apparently it has been broken for
2+ years now. There is also a known issue on with the DPAUX driver that
prevents it from probing, that was discussed on the #tegra IRC. Thierry,
please take a closer look at this driver and test it thoroughly, it has
some obvious problems.

 drivers/gpu/drm/tegra/dpaux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index d84e81ff36ad..ba5681fab73b 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -521,7 +521,7 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
 	 * is no possibility to perform the I2C mode configuration in the
 	 * HDMI path.
 	 */
-	err = tegra_dpaux_pad_config(dpaux, DPAUX_HYBRID_PADCTL_MODE_I2C);
+	err = tegra_dpaux_pad_config(dpaux, DPAUX_PADCTL_FUNC_I2C);
 	if (err < 0)
 		return err;
 
-- 
2.19.0



More information about the dri-devel mailing list