[PATCH v2 02/16] dt-bindings: display: renesas: lvds: Document r8a77990 bindings
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Sep 24 11:36:00 UTC 2018
Hi Laurent,
On 14/09/18 10:10, Laurent Pinchart wrote:
> The E3 (r8a77990) supports two LVDS channels. Extend the binding to
> support them.
This commit message sounds rather like we are modifying the bindings,
rather than just adding a compatible string. I went looking for extra
changes - but I see we only need a compatible addition.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo+renesas at jmondi.org>
Still, the change looks accurate to me - and at the moment I can't think
of a better description so:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas at ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 5a4e379bb414..13af7e2ac7e8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -15,6 +15,7 @@ Required properties:
> - "renesas,r8a7796-lvds" for R8A7796 (R-Car M3-W) compatible LVDS encoders
> - "renesas,r8a77970-lvds" for R8A77970 (R-Car V3M) compatible LVDS encoders
> - "renesas,r8a77980-lvds" for R8A77980 (R-Car V3H) compatible LVDS encoders
> + - "renesas,r8a77990-lvds" for R8A77990 (R-Car E3) compatible LVDS encoders
> - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS encoders
>
> - reg: Base address and length for the memory-mapped registers
>
--
Regards
--
Kieran
More information about the dri-devel
mailing list