[PATCH] drm/vmwgfx: Fix a buffer object eviction regression v2

Matthew Wilcox willy at infradead.org
Mon Sep 24 13:24:24 UTC 2018


On Mon, Sep 24, 2018 at 11:50:02AM +0000, Thomas Hellstrom wrote:
> Commit 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") introduced
> an incorrect return value from the function vmw_gmrid_man_get_node(),
> when we run out of integer ids. Instead of returning 0 (meaning
> non-fatal error) we forward the ida_simple_get error code -ENOSPC.
> This causes TTM not to retry allocation after buffer eviction and
> instead return -ENOSPC to user-space.
> 
> Fix this by returning 0 when ida_simple_get() returns other error codes
> than -ENOMEM:
> 
> Tested using glretrace.
> 
> Cc: <willy at infradead.org>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> Reviewed-by: Sinclair Yeh <syeh at vmware.com>

Reviewed-by: Matthew Wilcox <willy at infradead.org>


More information about the dri-devel mailing list