[PATCH] drm/hisilicon: Replace ttm_bo_unref with ttm_bo_put

[Xinliang Liu]

Hi Thomas, sorry for too late to reply.

On Tue, 31 Jul 2018 at 14:33, Thomas Zimmermann <tzimmermann at suse.de> wrote:
>
> The function ttm_bo_put releases a reference to a TTM buffer object. The
> function's name is more aligned to the Linux kernel convention of naming
> ref-counting function _get and _put.
>
> A call to ttm_bo_unref takes the address of the TTM BO object's pointer and
> clears the pointer's value to NULL. This is not necessary in most cases and
> sometimes even worked around by the calling code. A call to ttm_bo_put only
> releases the reference without clearing the pointer.
>
> The current behaviour of cleaning the pointer is kept in the calling code,
> but should be removed if not required in a later patch.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
Reviewed-by: Xinliang Liu <z.liuxinliang at hisilicon.com>
Applied to hisilicon-drm-next.

Thanks,
Xinliang

> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
> index 4871025f7573..2e3e0bdb8932 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
> @@ -283,7 +283,7 @@ static void hibmc_bo_unref(struct hibmc_bo **bo)
>                 return;
>
>         tbo = &((*bo)->bo);
> -       ttm_bo_unref(&tbo);
> +       ttm_bo_put(tbo);
>         *bo = NULL;
>  }
>
> --
> 2.18.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel