[PATCH] gpu: host1x: Remove redundant of_dma_configure() call

Thierry Reding thierry.reding at gmail.com
Wed Sep 26 14:13:40 UTC 2018


On Wed, Sep 26, 2018 at 04:10:54PM +0200, Thierry Reding wrote:
> On Wed, Sep 12, 2018 at 05:47:54PM +0100, Robin Murphy wrote:
> > Now that the Host1x bus_type implements a .dma_configure callback,
> > subdevices should automatically get configured for DMA as their drivers
> > bind, so there's no need to also force it at device creation time.
> > 
> > CC: Thierry Reding <thierry.reding at gmail.com>
> > CC: Mikko Perttunen <cyndis at kapsi.fi>
> > Signed-off-by: Robin Murphy <robin.murphy at arm.com>
> > ---
> > 
> > I *believe* my reasoning is correct here, but please shout if it's not.
> > 
> >  drivers/gpu/host1x/bus.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Applied, thanks.

Actually I was a little too quick on the trigger there. I don't think we
can remove this here because the of_dma_configure() in this call
configures the logical "compound" child device, whereas the
.dma_configure callback configures the physical device.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180926/780dd7de/attachment-0001.sig>


More information about the dri-devel mailing list