[PATCH] drm/etnaviv: fix build error due to change in scheduler struct

Christian König christian.koenig at amd.com
Thu Sep 27 09:28:59 UTC 2018


Am 27.09.2018 um 09:03 schrieb Lucas Stach:
> Am Donnerstag, den 27.09.2018, 08:27 +0200 schrieb Nayan Deshmukh:
>> The work_tdr field was moved from drm_sched_job to drm_gpu_scheduler
>> as part of a previous patch.
>>
>> Fixes: 4f07d88d8534 drm/scheduler: remove timeout work_struct from drm_sched_job
>> Signed-off-by: Nayan Deshmukh <nayan26deshmukh at gmail.com>
> Thanks, I guess whoever picked up the patch that gets fixed by this
> will pick this into the same tree. Did you also check VC5? I think they
> gained a similar timeout extension mechanism.

Thanks for pointing that out and yes there is also another reference in 
drivers/gpu/drm/v3d/v3d_sched.c.

Christian.

>
> Acked-by: Lucas Stach <l.stach at pengutronix.de>
>
>> ---
>>   drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_sched.c b/drivers/gpu/drm/etnaviv/etnaviv_sched.c
>> index 69e9b431bf1f..e7c3ed6c9a2e 100644
>> --- a/drivers/gpu/drm/etnaviv/etnaviv_sched.c
>> +++ b/drivers/gpu/drm/etnaviv/etnaviv_sched.c
>> @@ -105,7 +105,7 @@ static void etnaviv_sched_timedout_job(struct drm_sched_job *sched_job)
>>   	change = dma_addr - gpu->hangcheck_dma_addr;
>>   	if (change < 0 || change > 16) {
>>   		gpu->hangcheck_dma_addr = dma_addr;
>> -		schedule_delayed_work(&sched_job->work_tdr,
>> +		schedule_delayed_work(&sched_job->sched->work_tdr,
>>   				      sched_job->sched->timeout);
>>   		return;
>>   	}



More information about the dri-devel mailing list