[PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

Noralf Trønnes noralf at tronnes.org
Thu Sep 27 12:33:30 UTC 2018


Den 27.09.2018 10.49, skrev Alexey Brodkin:
> Hi Noralf,
>
> On Wed, 2017-11-15 at 15:19 +0100, Noralf Trønnes wrote:
>> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
>> the fact that drm_device holds a pointer to the drm_fb_helper structure.
>> This means that the driver doesn't have to keep track of that.
>> Also use the drm_fb_helper functions directly.
>> Remove unused function prototype arcpgu_fbdev_cma_init().
>>
>> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> Similarly to drm/fsl-dcu driver this one never made it upstream.
> I was under impression that entire series will be either accepted or not
> but looks like fixes for separate drivers were pulled via separate trees.
>
> Anyways I like this patch for ARC PGU and may confirm it works
> perfectly fine on top of 4.18.10 so should I pull this into my tree and
> send a pull-request to David or maybe all not yet accepted patches from the
> series may go through the same tree?
>
> -Alexey
>
> And essentially...
> Acked-by: Alexey Brodkin <abrodkin at synopsys.com>
>

It has been superseeded by this patch:

[02/20] drm/arc: Use drm_fbdev_generic_setup()
https://patchwork.freedesktop.org/patch/247862/

I'll reply to the cover letter of this series that it has been superseeded
and why.

Wrt to applying, I only do that if I get an ack from the driver maintainer
or a DRM maintainer for trivial stuff.
Some reply that they have applied/queued the patch in their tree for the
next version.

Noralf.



More information about the dri-devel mailing list