[PATCH] Revert "drm/panel: Add device_link from panel device to DRM device"

Linus Walleij linus.walleij at linaro.org
Fri Sep 28 08:19:42 UTC 2018


On Thu, Sep 27, 2018 at 3:50 PM Sean Paul <sean at poorly.run> wrote:

> What's different in your in-development driver that's causing you to hit
> this?

I think Andrzej answered it well, but I couldn't see what I did
different from the Exynos driver, so I was puzzled that it would
still work, but as it turns out that one breaks too.

As far as I can tell, the proper fix is more complex and require
embedding a struct device into struct drm_device like most
subsystems do and create a link to that device instead of
parent (dev->dev), because the parent device may be
the parent of several subdevices, not just the drm_device,
but also (in my case at least) the DSI devices. A typical case
would be if the DSI host is in the same address range as the
display controller (then it is usually represented by the same
device).

On other platforms the parent device may just be parent for
the drm_device but we can't just assume that.

Yours,
Linus Walleij


More information about the dri-devel mailing list