[PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

Noralf Trønnes noralf at tronnes.org
Fri Sep 28 10:42:50 UTC 2018

Den 28.09.2018 09.34, skrev Alexey Brodkin:
> Hi Noralf,
> On Sat, 2018-09-08 at 15:46 +0200, Noralf Trønnes wrote:
>> The CMA helper is already using the drm_fb_helper_generic_probe part of
>> the generic fbdev emulation. This patch makes full use of the generic
>> fbdev emulation by using its drm_client callbacks. This means that
>> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
>> now handled by the emulation code. Additionally fbdev unregister happens
>> automatically on drm_dev_unregister().
>> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
>> driver. This is done to highlight the fact that fbdev emulation is an
>> internal client that makes use of the driver, it is not part of the
>> driver as such. If fbdev setup fails, an error is printed, but the driver
>> succeeds probing.
>> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> Thanks for doing that!
> Quite some code removed from the driver and still FBDEV emulation works :)

Yeah we're down to one line of code in the driver to get fbdev emulation
which is quite nice a think :D


> Acked-by: Alexey Brodkin <abrodkin at synopsys.com>

More information about the dri-devel mailing list