[PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
Bartlomiej Zolnierkiewicz
b.zolnierkie at samsung.com
Mon Apr 1 15:46:41 UTC 2019
On 03/20/2019 11:07 AM, Lee Jones wrote:
>>>> On 02/12/2019 09:42 AM, Lee Jones wrote:
>>>>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
>>>>>
>>>>>>
>>>>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
>>>>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
>>>>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>>>>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>>>>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>>>>>>>> and converts LCD_CLASS_DEVICE into a menu.
>>>>>>>>
>>>>>>>> Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
>>>>>>>
>>>>>>> A cover letter with the v1 -> v2 changelog would be nice... but
>>>>>>> nevertheless:
>>>>>>> Acked-by: Daniel Thompson <daniel.thompson at linaro.org>
>>>>>>
>>>>>> Also:
>>>>>>
>>>>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
>>>>>>
>>>>>> Lee, will you pick this up or do you want me to do it?
>>>>>
>>>>> You can take them if you want. I will require a pull-request from an
>>>>> independent immutable branch though please.
>>>>
>>>> OK, immutable branch will also allow other trees (drm) to sync with
>>>> these changes if desired.
>>>>
>>>> I will do it for v5.2 if you are fine with it (too late for v5.1
>>>> IMHO and I also won't have time too fix any potential issues next
>>>> week).
>
>>> Topic branch for these 2 simple patches seems like serious overkill.
>
> [...]
>
>>> Would be good to get it into 5.1 still though, just to avoid too
>>> many conflicts.
>
> I think you just answered your own statement. :)
>
>> Well, if so I'm also fine with this going in 5.1 w/o topic branch.
>>
>> Lee, do you want to merge this directly into backlight tree (you
>> have now both fbdev and drm acks)?
>
> It was too late for v5.1.
>
> Do you still want to take this for v5.2, or should I take them and
> provide you with an immutable pull-request?
Please take them and provide immutable branch, thank you.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
More information about the dri-devel
mailing list