[PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support
Tomi Valkeinen
tomi.valkeinen at ti.com
Wed Apr 3 11:34:40 UTC 2019
On 02/04/2019 05:16, Andrey Smirnov wrote:
> The early return above causes tc_get_display_props() to never be
> called for eDP case, which in turn result in tc_mode_valid() returning
> MODE_BAD for every mode it is given since it depends on tc->link.base
> being initialized properly. I had to change this code to:
>
> if (tc->hpd_num < 0) {
> if (!tc->panel)
> return connector_status_unknown;
>
> conn = true;
> } else {
> tc_read(GPIOI, &val);
>
> conn = val & BIT(tc->hpd_num);
> }
>
> to fix the problem.
Ah, right. There's tc_get_display_props() in tc_bridge_enable() but
that's of course too late (and maybe even not needed at all).
What you suggest here looks fine to me, so I'll change my patch
accordingly. Thanks!
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
More information about the dri-devel
mailing list