[PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

Sam Ravnborg sam at ravnborg.org
Thu Apr 4 19:08:58 UTC 2019


Hi Joe.

> > >  
> > >  	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> > >  	if (ret < 0) {
> > > -		DRM_DEV_ERROR(dev, "Failed to exit sleep mode");
> > > +		DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n");
> > 
> > I was under the impression that newlines was optional these days.
> > Should we always use them with logging?
> 
> Yes.
> 
> The general problem is KERN_CONT/pr_cont uses where interleaving
> is still possible from multiple threads.
> 
> > I did not find any obvious clues in linux/printk.h
> 
> I'll see about adding something one day to the Documentation.
> Likely in coding-style.rst.

Thanks for the clarification.
A seperate doc on logging would be awesome.

	Sam


More information about the dri-devel mailing list