Re: [PATCH 4/7] drm/omap: fix possible object reference leak
wen.yang99 at zte.com.cn
wen.yang99 at zte.com.cn
Mon Apr 8 01:24:20 UTC 2019
> > The call to of_find_matching_node returns a node pointer with refcount
> > incremented thus it must be explicitly decremented after the last
> > usage.
> >
> > Detected by coccinelle with the following warnings:
> > drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:212:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function.
> > drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:237:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 209, but without a corresponding object release within this function.
> >
> > Signed-off-by: Wen Yang <wen.yang99 at zte.com.cn>
> > Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > Cc: Sebastian Reichel <sebastian.reichel at collabora.com>
> > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > Cc: dri-devel at lists.freedesktop.org
> > Cc: linux-kernel at vger.kernel.org
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> Would you like to get the series merged in one go, or individual patches
> picked by the respective maintainer ?
Thank you.
We are sorry that we did not respond in time because of
the Ching Ming Festival holiday.
In our opinion, both ways are fine.
In addition, we just checked and found that some patches
have been selected by the maintainers.
--
Regards,
Wen
More information about the dri-devel
mailing list