[PATCH v5 1/7] dt-bindings: Add panel-timing subnode to simple-panel
Thierry Reding
thierry.reding at gmail.com
Mon Apr 8 10:32:40 UTC 2019
On Mon, Apr 01, 2019 at 10:17:18AM -0700, Douglas Anderson wrote:
> From: Sean Paul <seanpaul at chromium.org>
>
> This patch adds a new subnode to simple-panel allowing us to override
> the typical timing expressed in the panel's display_timing.
>
> Changes in v2:
> - Split out the binding into a new patch (Rob)
> - display-timings is a new section (Rob)
> - Use the full display-timings subnode instead of picking the timing
> out (Rob/Thierry)
> Changes in v3:
> - Go back to using the timing subnode directly, but rename to
> panel-timing (Rob)
> Changes in v4:
> - Simplify desc. for when override should be used (Thierry/Laurent)
> - Removed Rob H review since it's been a year and wording changed
> Changes in v5:
> - Removed bit about OS may ignore (Rob/Ezequiel)
>
> Cc: Doug Anderson <dianders at chromium.org>
> Cc: Eric Anholt <eric at anholt.net>
> Cc: Heiko Stuebner <heiko at sntech.de>
> Cc: Jeffy Chen <jeffy.chen at rock-chips.com>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Stéphane Marchesin <marcheu at chromium.org>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> Cc: devicetree at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-rockchip at lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul at chromium.org>
> Signed-off-by: Douglas Anderson <dianders at chromium.org>
> ---
>
> .../bindings/display/panel/simple-panel.txt | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> index b2b872c710f2..93882268c0b9 100644
> --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> @@ -15,6 +15,16 @@ Optional properties:
> (hot plug detect) signal, but the signal isn't hooked up so we should
> hardcode the max delay from the panel spec when powering up the panel.
>
> +panel-timing subnode
Is there any reason why we need the panel- prefix? This is already part
of a panel definition, so it's completely redundant. Why not just name
the subnode "timing"?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190408/d4720b0d/attachment.sig>
More information about the dri-devel
mailing list