[PATCH] drm/ttm: fix incrementing the page pointer for huge pages

[Michel Dänzer]

On 2019-04-10 11:45 a.m., Christian König wrote:
> When we increment the counter we need to increment the pointer as well.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Fixes: e16858a7e6e7 drm/ttm: fix start page for huge page check in ttm_put_pages()
> ---
>  drivers/gpu/drm/ttm/ttm_page_alloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> index c74147f0cbe3..627f8dc91d0e 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> @@ -733,7 +733,7 @@ static void ttm_put_pages(struct page **pages, unsigned npages, int flags,
>  			if (!(flags & TTM_PAGE_FLAG_DMA32) &&
>  			    (npages - i) >= HPAGE_PMD_NR) {
>  				for (j = 1; j < HPAGE_PMD_NR; ++j)
> -					if (p++ != pages[i + j])
> +					if (++p != pages[i + j])
>  					    break;
>  
>  				if (j == HPAGE_PMD_NR)
> @@ -768,7 +768,7 @@ static void ttm_put_pages(struct page **pages, unsigned npages, int flags,
>  				break;
>  
>  			for (j = 1; j < HPAGE_PMD_NR; ++j)
> -				if (p++ != pages[i + j])
> +				if (++p != pages[i + j])
>  				    break;
>  
>  			if (j != HPAGE_PMD_NR)
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer